[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query
Date: Tue, 31 Jul 2012 10:50:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

Il 31/07/2012 10:47, Kevin Wolf ha scritto:
>>> >> Why did you convert the initialisation to separate statement? If you
>>> >> really want to do this, I think using g_new0 would be safer now, but I
>>> >> actually like compound literals better.
>> > 
>> > Later on I will have some more initialization beyond the list of fields,
>> > so I preferred an explicit list.  I can change it back if you prefer.
> What I'm really interested in is having zero-initialisation for any not
> explicitly initialised fields, just to be on the safe side. You can do
> that with g_new0() or with compound literals, that's a matter of taste.

Yes, and in fact I even have a change to g_new0 later in the series.
I'll squash that change in this patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]