Re: [Qemu-devel] [PATCH] configure: fix libcap detection

[Blue Swirl]

On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell <address@hidden> wrote:
> On 31 July 2012 17:33, Stefan Weil <address@hidden> wrote:
>> please apply http://patchwork.ozlabs.org/patch/171067/,
>> or we'll get a 4th bug fix for this.
>>
>> Peter sent a series with this one and more patches on
>> 2012-07-18 (1st: http://patchwork.ozlabs.org/patch/171686/).
>> At least the first 10 of them should be applied.
>
> More accurately:
>  * apply the valgrind patch first:
>    http://patchwork.ozlabs.org/patch/174029/
>  * then apply the 11 patch configure series
>
> I believe the valgrind test patch should fix the issues Blue Swirl
> was seeing with the 11-patch series (and I tested it on debian
> squeeze which I think has the same gcc Blue was using).
>
> Patch 11/11 does enable -Werror on test code in a way which
> causes configure to fail noisily if it encounters a warning:
> I think it's better to commit this early rather than late
> because then we can fix any lingering problems with odd
> hosts or configurations which I missed. (The noisy failure
> includes a clear message about how to work around it in
> the interim, which is better than our current situation IMHO.)

There are still problems, this time with Debian testing:
ERROR: configure test passed without -Werror but failed with -Werror.
This is probably a bug in the configure script. The failing command
will be at the bottom of config.log.
You can run configure with --disable-werror to bypass this check.

f--19750-.exe /tmp/qemu-conf--19750-.c -Wl,-z,relro -Wl,-z,now -pie -m64 -g
/tmp/qemu-conf--19750-.c:1:31: fatal error: valgrind/valgrind.h: No
such file or directory
compilation terminated.
gcc -fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall
-Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
-fstack-protector-all -Wendif-labels -Wmissing-include-dirs
-Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k
-Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -I/usr/include/libpng12
-I/usr/include/nss -I/usr/include/nspr -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-o /tmp/qemu-conf--19750-.exe /tmp/qemu-conf--19750-.c -Wl,-z,relro
-Wl,-z,now -pie -m64 -g
gcc -Werror -fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall
-Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
-fstack-protector-all -Wendif-labels -Wmissing-include-dirs
-Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k
-Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -I/usr/include/libpng12
-I/usr/include/nss -I/usr/include/nspr -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-o /tmp/qemu-conf--19750-.exe /tmp/qemu-conf--19750-.c -Wl,-z,relro
-Wl,-z,now -pie -m64 -g

>
> thanks
> -- PMM