[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public |
Date: |
Wed, 01 Aug 2012 07:53:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 07/31/2012 10:51 AM, Dong Xu Wang wrote:
> In add-cow file format, we will use path_has_protocol and we will read
> a NUL-terminated string from image , qed_read_string has done the samething,
s/image ,/image,/
s/samething/same thing/
> so make the two functions public, then we will reuse them directly.
>
> While creating images files, if no size is specified, will use size of backing
> file. If no backing file is specified, we will use the size of image file.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> ---
> block.c | 37 +++++++++++++++++++++++++++++++++----
> block.h | 3 +++
> block/qed.c | 29 +----------------------------
> 3 files changed, 37 insertions(+), 32 deletions(-)
>
> + /* The size for the image must always be specified, with one exception:
> + If we are using a backing file, we can obtain the size from there,
> + but if not, and we are using an image file, we will obtain the size
> from it.*/
grammar:
The size for the image must be known, either by direct specification, or
by reading it from a backing file or image file.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public,
Eric Blake <=