[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts a
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked |
Date: |
Wed, 1 Aug 2012 18:41:45 +0200 |
From: Yang Zhang <address@hidden>
If an interrupt flag is already set when the interrupt becomes enabled,
raise an interrupt immediately, and vice versa if interrupts become
disabled.
Signed-off-by: Yang Zhang <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/mc146818rtc.c | 9 +++++++++
hw/mc146818rtc_regs.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index b99f4d3..293f174 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -220,6 +220,15 @@ static void cmos_ioport_write(void *opaque, uint32_t addr,
uint32_t data)
rtc_set_time(s);
}
}
+ /* if an interrupt flag is already set when the interrupt
+ * becomes enabled, raise an interrupt immediately. */
+ if (data & s->cmos_data[RTC_REG_C] & REG_C_MASK) {
+ s->cmos_data[RTC_REG_C] |= REG_C_IRQF;
+ qemu_irq_raise(s->irq);
+ } else {
+ s->cmos_data[RTC_REG_C] &= ~REG_C_IRQF;
+ qemu_irq_lower(s->irq);
+ }
s->cmos_data[RTC_REG_B] = data;
periodic_timer_update(s, qemu_get_clock_ns(rtc_clock));
break;
diff --git a/hw/mc146818rtc_regs.h b/hw/mc146818rtc_regs.h
index 3ab3770..fc10076 100644
--- a/hw/mc146818rtc_regs.h
+++ b/hw/mc146818rtc_regs.h
@@ -58,5 +58,6 @@
#define REG_C_IRQF 0x80
#define REG_C_PF 0x40
#define REG_C_AF 0x20
+#define REG_C_MASK 0x70
#endif
--
1.7.10.4
- [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 02/10] RTC: Rename rtc_timer_update, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 06/10] RTC: Add divider reset support, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 07/10] RTC: Do not fire timer periodically to catch next alarm, Paolo Bonzini, 2012/08/01