[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEV
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED |
Date: |
Thu, 2 Aug 2012 11:53:19 -0300 |
On Thu, 02 Aug 2012 15:57:24 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 02/08/2012 15:53, Markus Armbruster ha scritto:
> >> > Is this anything that an external application can reproduce?
> >> >
> >> > Perhaps we need to keep QERR_DEVICE_ENCRYPTED even if libvirt does not
> >> > use it, or at least provide an alternative mechanism (e.g. an event) to
> >> > realize its effect.
> > Not sure I get you.
> >
> > External applications should use QMP.
>
> Yes. Is there a conceivable scenario in which a QMP client needs to
> look at QERR_DEVICE_ENCRYPTED?
>
> > A sane way to change media in QMP needs to provide the key as argument.
>
> How does the QMP client know that the device is encrypted, and thus they
> have to ask for the key and retry?
It would be interesting to know how libvirt handles this.
>
> Same for hmp_cont, by the way.
>
> > If the key is wrong, fail the change cleanly. In particular, don't
> > eject then.
>
> Agreed on not ejecting, but this is orthogonal.
>
> Paolo
>
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, (continued)
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, Luiz Capitulino, 2012/08/10
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, Markus Armbruster, 2012/08/11
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, Luiz Capitulino, 2012/08/13
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, Markus Armbruster, 2012/08/13
- Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field, Luiz Capitulino, 2012/08/13
[Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED, Luiz Capitulino, 2012/08/01
Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED, Luiz Capitulino, 2012/08/02
Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED, Luiz Capitulino, 2012/08/02
[Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Luiz Capitulino, 2012/08/01
- Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Luiz Capitulino, 2012/08/02
- Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Markus Armbruster, 2012/08/02
- Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Luiz Capitulino, 2012/08/02
- Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Amos Kong, 2012/08/06
- Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno, Luiz Capitulino, 2012/08/06
[Qemu-devel] [PATCH 17/34] qerror: drop QERR_SOCKET_CONNECT_IN_PROGRESS, Luiz Capitulino, 2012/08/01