[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/10] RTC: Remove the logic to update time forma
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v3 01/10] RTC: Remove the logic to update time format when DM bit changed |
Date: |
Thu, 2 Aug 2012 18:04:04 +0200 |
From: Yang Zhang <address@hidden>
Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal
registers. It only indicates what format is used for those registers.
Signed-off-by: Yang Zhang <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/mc146818rtc.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 3777f85..6e5b2f0 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -220,15 +220,7 @@ static void cmos_ioport_write(void *opaque, uint32_t addr,
uint32_t data)
rtc_set_time(s);
}
}
- if (((s->cmos_data[RTC_REG_B] ^ data) & (REG_B_DM | REG_B_24H)) &&
- !(data & REG_B_SET)) {
- /* If the time format has changed and not in set mode,
- update the registers immediately. */
- s->cmos_data[RTC_REG_B] = data;
- rtc_copy_date(s);
- } else {
- s->cmos_data[RTC_REG_B] = data;
- }
+ s->cmos_data[RTC_REG_B] = data;
rtc_timer_update(s, qemu_get_clock_ns(rtc_clock));
break;
case RTC_REG_C:
--
1.7.10.4
- [Qemu-devel] [PATCH v3 00/10] Remove periodic wakeup from RTC timer, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 01/10] RTC: Remove the logic to update time format when DM bit changed,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v3 04/10] RTC: Update interrupt state when interrupts are masked/unmasked, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 02/10] RTC: Rename rtc_timer_update, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 03/10] RTC: introduce RTC_CLOCK_RATE, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 05/10] vmstate: add VMSTATE_TIMER_V, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 06/10] RTC: Update the RTC clock only when reading it, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 08/10] RTC: Do not fire timer periodically to catch next alarm, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 07/10] RTC: Add divider reset support, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 09/10] RTC: Get and set time without going through s->current_tm, Paolo Bonzini, 2012/08/02
- [Qemu-devel] [PATCH v3 10/10] RTC: Remove the current_tm field, Paolo Bonzini, 2012/08/02