[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redund
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH 1/3] socket: remove redundant check |
Date: |
Thu, 2 Aug 2012 22:59:29 -0400 (EDT) |
----- Original Message -----
> Stefan Hajnoczi <address@hidden> writes:
>
> > On Wed, Aug 01, 2012 at 04:59:01PM +0800, Amos Kong wrote:
> >> It's aleady in the end of loop, error should be set.
> >>
> >> Signed-off-by: Amos Kong <address@hidden>
> >> ---
> >> qemu-sockets.c | 4 +---
> >> 1 files changed, 1 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/qemu-sockets.c b/qemu-sockets.c
> >> index 668fa93..c636882 100644
> >> --- a/qemu-sockets.c
> >> +++ b/qemu-sockets.c
> >> @@ -181,9 +181,7 @@ int inet_listen_opts(QemuOpts *opts, int
> >> port_offset, Error **errp)
> >> fprintf(stderr,"%s: bind(%s,%s,%d): %s\n",
> >> __FUNCTION__,
> >> inet_strfamily(e->ai_family), uaddr,
> >> inet_getport(e),
> >> strerror(errno));
> >> - if (!e->ai_next) {
> >> - error_set(errp, QERR_SOCKET_BIND_FAILED);
> >> - }
> >> + error_set(errp, QERR_SOCKET_BIND_FAILED);
> >> }
> >> }
> >> closesocket(slisten);
> >
> > This isn't obvious. It looks like the intent of the if
> > (!e->ai_next) is
> > to suppress the error so that the next iteration of the *outer*
> > loop can
> > succeed.
> >
> > Why is it okay to set QERR_SOCKET_BIND_FAILED? We may have more
> > addrinfos left to try in the outer loop. They may succeed so we
> > don't
> > want an error in that case.
>
> You are correct, and the patch is wrong.
Yeah, will drop this patch from this thread.
Thanks.
> See also related
> http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00772.html
>
>
Message not available
Message not available