[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h |
Date: |
Fri, 3 Aug 2012 10:00:58 -0300 |
On Fri, 3 Aug 2012 11:51:02 +0100
Stefan Hajnoczi <address@hidden> wrote:
> From: Amos Kong <address@hidden>
>
> Signed-off-by: Amos Kong <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> qemu_socket.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/qemu_socket.h b/qemu_socket.h
> index 4689ff3..1a2f517 100644
> --- a/qemu_socket.h
> +++ b/qemu_socket.h
> @@ -27,7 +27,6 @@ int inet_aton(const char *cp, struct in_addr *ia);
> #endif /* !_WIN32 */
>
> #include "qemu-option.h"
> -#include "error.h"
> #include "qerror.h"
nack on this one, as it's dropping the wrong file.
qemu_socket.h declares functions that take an Error argument, so it has
to include error.h.
However, qerror.h should be dropped and any build breakage should be
fixed by including qerror.h in the .c files it's missing.
>
> /* misc helpers */
- [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 3/7] remove unused include of error.h, Stefan Hajnoczi, 2012/08/03
- Re: [Qemu-devel] [PATCH 3/7] remove unused include of error.h,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 2/7] qom: Clean libuser object and dependency files, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 1/7] usb: Clean common object and dependency files, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 5/7] exec.c: Fix off-by-one error in register_subpage, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 7/7] exec.c: Remove out of date comment, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 6/7] exec.c: Use subpages for large unaligned mappings, Stefan Hajnoczi, 2012/08/03
- [Qemu-devel] [PATCH 4/7] socket: clean up redundant assignment, Stefan Hajnoczi, 2012/08/03
- Re: [Qemu-devel] [PULL 0/7] Trivial patches for 22 July to 3 August 2012, Stefan Hajnoczi, 2012/08/03