Re: [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390

[Blue Swirl]

On Tue, Aug 7, 2012 at 12:26 PM, Peter Maydell <address@hidden> wrote:
> On 7 August 2012 13:19, Christian Borntraeger <address@hidden> wrote:
>> +#if defined(TARGET_HAS_USB) && (TARGET_HAS_USB == 1)
>>      /* init USB devices */
>>      if (usb_enabled) {
>>          if (foreach_device_config(DEV_USB, usb_parse) < 0)
>>              exit(1);
>>      }
>> +#endif
>
> Whether there is USB or not is a property of the machine model,
> not the target CPU architecture, so a TARGET_HAS_USB define
> is definitely the wrong approach.

Yes. I'd add CONFIG_USB=y to files in default-configs/ except for
s390*, Sparc32 and user emulators. Unless it's enough for USB to have
a dependency on PCI?

>
> -- PMM
>