[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close().
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close(). |
Date: |
Wed, 8 Aug 2012 16:06:36 +0100 |
On Tue, Aug 7, 2012 at 9:30 PM, Blue Swirl <address@hidden> wrote:
> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet <address@hidden> wrote:
>> +static void quorum_close(BlockDriverState *bs)
>> +{
>> + BDRVQuorumState *s = bs->opaque;
>> + int i;
>> +
>> + /* Ensure writes reach stable storage */
>> + for (i = 0; i <= 2; i++) {
>> + bdrv_flush(s->bs[i]);
>
> bdrv_close()
bdrv_delete() instead of close since we did bdrv_new() to allocate them.
We also need to g_free() the filenames.
- [Qemu-devel] [PATCH 00/10] Quorum disk image corruption resiliency, Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 02/10] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 01/10] quorum: Create quorum .c, add QuorumSingleAIOCB and QuorumAIOCB., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open()., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 04/10] quorum: Add quorum_close()., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength()., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 08/10] quorum: Add quorum_co_flush()., Benoît Canet, 2012/08/07
- [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2012/08/07
[Qemu-devel] [RFC V2 09/10] quorum: Add quorum_aio_readv., Benoît Canet, 2012/08/07