[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/2] block: Support GlusterFS as a QEMU block
Bharata B Rao
Re: [Qemu-devel] [PATCH v5 2/2] block: Support GlusterFS as a QEMU block backend
Wed, 8 Aug 2012 20:38:57 +0530
On Wed, Aug 08, 2012 at 03:37:31PM +0100, Stefan Hajnoczi wrote:
> I have left a few small comments. Perhaps you can resend with your
> fixes to Patch 1?
Sure, Will send v6 with fixes to patch 1 and incorporating your suggestions.
> > + */
> > +#include "block_int.h"
> > +#include <glusterfs/api/glfs.h>
> System headers followed by user headers is a good order to prevent
> application-specific macros from interfering with system headers:
> #include <glusterfs/api/glfs.h>
> #include "block_int.h"
> > + *'port' is the port number on which gluster management daemon (glusterd)
> > is
> Missing space: * 'port'
> > + error_report("Usage: file=gluster://server:[port]/volname/image"
Sharp eyes! Will fix.
> > +
> > + /*
> > + * TODO: Use GF_LOG_ERROR instead of hard code value of 4 here when
> > + * GlusterFS exports it in a header.
> > + */
> > + ret = glfs_set_logging(glfs, "-", 4);
> Are you submitting the GlusterFS patch to move
> gf_loglevel_t/GF_LOG_ERROR to the API headers?
I have already informed them about this. I will work with them to make sure
that GL_LOG_* definitions are available for the users of libgfapi.