Re: [Qemu-devel] [PATCH v3] Support 'help' as a synonym for '?' in command line options

[Eric Blake]

On 08/09/2012 03:02 PM, Peter Maydell wrote:
> On 9 August 2012 20:25, Eduardo Habkost <address@hidden> wrote:
>> On Fri, Aug 03, 2012 at 03:42:39PM -0500, Anthony Liguori wrote:
>>> Peter Maydell <address@hidden> writes:
>>>> For command line options which permit '?' meaning 'please list the
>>>> permitted values', add support for 'help' as a synonym, by abstracting
>>>> the check out into a helper function.
> 
>>> Applied. Thanks.
>>
>> I just found out that this patch broke "-cpu ?dump", "-cpu ?cpuid", and
>> "-cpu ?model":
> 
> These options appear to be completely undocumented. They're also pretty
> ugly syntax and seem to be x86 specific.

Thankfully, libvirt is not using them.  If there is a reason for libvirt
to start using them, then libvirt would rather go through QMP than any
new syntax when talking to newer qemu (that is, I'm okay if we
completely lose the spelling as long as we don't lose the feature).

> 
> Any suggestions for what the sane syntax for these options would be?
> (ie the analogous change to having '?' go to 'help').

-cpu help=dump
-cpu help=cpuid

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature