[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue |
Date: |
Fri, 10 Aug 2012 07:59:30 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 09, 2012 at 05:55:50PM +0000, Blue Swirl wrote:
> On Thu, Aug 9, 2012 at 2:45 PM, Paolo Bonzini <address@hidden> wrote:
> > @@ -244,7 +244,7 @@ void qemu_net_queue_flush(NetQueue *queue)
> > packet->size);
> > if (ret == 0) {
> > QTAILQ_INSERT_HEAD(&queue->packets, packet, entry);
> > - break;
> > + return 0;
>
> return false;
>
> > }
> >
> > if (packet->sent_cb) {
> > @@ -253,4 +253,5 @@ void qemu_net_queue_flush(NetQueue *queue)
> >
> > g_free(packet);
> > }
> > + return 1;
>
> return true;
Will fix these up when merging. I think it's clearer to use bool too.
Stefan
- [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen, Paolo Bonzini, 2012/08/09
- [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue, Paolo Bonzini, 2012/08/09
- [Qemu-devel] [PATCH 3/3] xen: flush queue when getting an event, Paolo Bonzini, 2012/08/09
- [Qemu-devel] [PATCH 2/3] e1000: flush queue whenever can_receive can go from false to true, Paolo Bonzini, 2012/08/09
- Re: [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen, Stefan Hajnoczi, 2012/08/09
- Re: [Qemu-devel] [PATCH 0/3] net: add missing queue flush for e1000 and xen, Amos Kong, 2012/08/29