qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline param


From: Yonit Halperin
Subject: Re: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params
Date: Mon, 13 Aug 2012 12:00:41 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

Ack
On 08/13/2012 11:32 AM, Christophe Fergeau wrote:
When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name' helper makes sure we
error out in this case. Looking at git history, the use of
'name2enum' instead of 'parse_name' seems to have been an oversight,
so let's change to that now.

Fixes rhbz#831708
---
  ui/spice-core.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 4fc48f8..bb4f585 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -344,7 +344,8 @@ static const char *stream_video_names[] = {
      [ SPICE_STREAM_VIDEO_FILTER ] = "filter",
  };
  #define parse_stream_video(_name) \
-    name2enum(_name, stream_video_names, ARRAY_SIZE(stream_video_names))
+    parse_name(_name, "stream video control", \
+               stream_video_names, ARRAY_SIZE(stream_video_names))

  static const char *compression_names[] = {
      [ SPICE_IMAGE_COMPRESS_OFF ]      = "off",




reply via email to

[Prev in Thread] Current Thread [Next in Thread]