[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols |
Date: |
Mon, 13 Aug 2012 08:44:29 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Peter Maydell <address@hidden> writes:
> On 10 August 2012 17:04, Anthony Liguori <address@hidden> wrote:
>> This lets us provide a default implementation of a symbol which targets can
>> override.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>
> I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS
> builds :-)
Thank you for testing it. I neglected to mention that I did a fair bit
of investigation before hand and was able to confirm that all platforms
we care about (Windows, Linux/Unix, OS X) and all compilers we care
about (GCC, LLVM) support weak symbols.
There may be different attribute names across compilers--it wasn't very
clear to me, but they definitely all have the feature in some form.
Regards,
Anthony Liguori
>
> -- PMM
- [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2), Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols, Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpu-definitions (v2), Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 7/7] target-ppc: add implementation of query-cpu-definitions (v2), Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable, Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 5/7] qapi: add query-cpu-definitions command (v2), Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command, Anthony Liguori, 2012/08/10
- [Qemu-devel] [PATCH 3/7] qapi: add query-machines command, Anthony Liguori, 2012/08/10
- Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2), Luiz Capitulino, 2012/08/13