qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 1/2] qdev: split up header so it can be used in cpu.h
Date: Wed, 15 Aug 2012 17:11:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0

Am 10.08.2012 19:00, schrieb Anthony Liguori:
> Header file dependency is a frickin' nightmare right now.  cpu.h tends to get
> included in our 'include everything' header files but qdev also needs to 
> include
> those headers mainly for qdev-properties since it knows about CharDriverState
> and friends.
> 
> We can solve this for now by splitting out qdev.h along the same lines that we
> previously split the C file.  Then cpu.h just needs to include qdev-core.h
> 
> Signed-off-by: Anthony Liguori <address@hidden>
> Signed-off-by: Anthony Liguori <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

Quickly looked through and qdev.h split looks fine.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]