[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC |
Date: |
Mon, 20 Aug 2012 04:48:31 -0400 (EDT) |
> On 08/20/12 10:00, Alon Levy wrote:
> >> Hi,
> >>
> >>>>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define
> >>>>> QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> >>>>
> >>>> Just delete this and use
> >>>> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> >>>
> >>> So you are telling me to undo a change that Gerd asked for -
> >>> could you please at least debate about the merits of both
> >>> approaches? the point of having QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> >>> always defined was to allow usage of #if without defined, which
> >>> is shorter.
> >>
> >> Hmm? That wasn't that I meant, must have been a tyops. I mean you
> >> should just do ...
> >>
> >> #ifndef QXL_IO_MONITORS_CONFIG_ASYNC <--- without
> >> *_HAS_* #define QXL_IO_MONITORS_CONFIG_ASYNC $value #endif
> >>
> >> then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
> >> #ifdefs) at all ...
> >
> > So you want me to give the io a value
>
> Well, it has one, right? [ checking spice-protocol ] It's 24.
Yes, I'll define it as (the_previous_one + 1).
>
> > - at this point I'd rather just add spice-protocol as a submodule,
> > then we don't need to do any of this. How about it?
>
> No. You can build qemu without submodules today as they are used for
> ROMS only (which are also provided as precompiled binaries).
Makes sense, I misunderstood the use of the submodules in qemu.
>
> Maybe revisit upstream spice packaging? spice internal usage of
> spice-protocol is handled via submodules now. Are there external
> users,
> other than qemu? Does it make sense to keep the spice-server /
> spice-protocol split in the first place? Or should spice-server just
> provide the protocol headers too?
spice-server is a much larger project then spice-protocol. The agents and the
drivers don't need any bits in spice-server. Sure, we can unify them - it would
make it easier for qemu and Xspice (the only other external user). But
submodule usage would be harder then. I actually like the current
submodularization of spice-protocol - it's a small header only repository that
is fast to fetch.
>
> cheers,
> Gerd
>
>
- [Qemu-devel] [PATCH v6 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, (continued)
- [Qemu-devel] [PATCH v6 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC,
Alon Levy <=
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
[Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions, Alon Levy, 2012/08/17