Re: [Qemu-devel] [PATCH] boards: add a 'none' machine type to all platforms

[Anthony Liguori]

Andreas Färber <address@hidden> writes:

> Am 23.08.2012 00:42, schrieb Anthony Liguori:
>> Peter Maydell <address@hidden> writes:
>> 
>>> On 22 August 2012 21:24, Anthony Liguori <address@hidden> wrote:
>>>
>>> We seem to be about evenly split about whether machine_init()
>>> should have a trailing semicolon (it doesn't need one
>>> but it doesn't hurt either...)
>> 
>> It's obviously superior to use a semicolon...  C is completely
>> consistent synactically about the usage of semicolons afterall :-)
>
> I disagree. This macro does not turn into a statement but a full
> function definition. Neither our Coding Style nor any other that I know
> does

I was only responding to be funny.  This is not something worth anyone
arguing about.  We've got *much* more important things to sort through.

Regards,

Anthony Liguori

>
> void foo(bar baz)
> {
> };
>
> with a trailing semicolon. For type_init() I cleaned this up, and I
> attribute the existing semicolons to people's ignorance of what these
> macros actually do.
>
> You might remember that Eduardo and I wanted to QOM'ify machines so that
> machine_init() would get replaced with type_init() but you stopped us at
> the time, leaving it untouched. So there's no strict need to go through
> and change existing users, but I believe in setting good examples.
>
> Regards,
> Andreas
>
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg