[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] libqblock APIs
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] libqblock APIs |
Date: |
Tue, 04 Sep 2012 11:15:51 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 |
δΊ 2012-9-3 21:18, Paolo Bonzini ει:
Il 03/09/2012 11:18, Wenchao Xia ha scritto:
1 QBroker. These structure was used to retrieve errors, every thread must
create one first, Later maybe thread related staff could be added into it.
Can you use GError instead?
read through the GError doc, GError is defined as following:
struct GError {
GQuark domain;
gint code;
gchar *message;
};
I am worried about the message member, I guess program would be
aborted if OOM, which I was tring to avoid, so I used char err_msg[1024]
in my code, and make things simpler.
3 QBlockInfoImageStatic. Now it is not folded with location and format.
What does "Static" mean?
It is about sorting the information into following kinds:
1) static. It is values that defined at creating time/modifying time,
mostly some settings, and it would not be automatically changed in I/O.
2) dynamic. Some information that would changes in I/O and other
operations, such as allocated_size, snapshots.
3) statistics.
Now only static one is provided, so I added _static suffix.
Paolo
--
Best Regards
Wenchao Xia
- [Qemu-devel] [PATCH 0/6] libqblock, qemu block layer library, Wenchao Xia, 2012/09/03
- Re: [Qemu-devel] [PATCH 1/6] libqblock APIs, Eric Blake, 2012/09/03
- Re: [Qemu-devel] [PATCH 1/6] libqblock APIs, Wenchao Xia, 2012/09/04
- Re: [Qemu-devel] [PATCH 1/6] libqblock APIs, Eric Blake, 2012/09/04
- Re: [Qemu-devel] [PATCH 1/6] libqblock APIs, Paolo Bonzini, 2012/09/04