|
From: | Don Slutz |
Subject: | Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs. |
Date: | Thu, 6 Sep 2012 15:00:47 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120824 Thunderbird/15.0 |
On 09/06/12 14:40, Eduardo Habkost wrote:
On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas Färber wrote:Am 30.08.2012 21:20, schrieb Don Slutz:This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allow this to work in accel=tcg mode. The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and hyper_extra_b can be used to further adjust what the guest sees. Signed-off-by: Don Slutz <address@hidden> --- target-i386/cpu.c | 178 +++++++++++++++++++++++++++++++++++++++++++++++++++++ target-i386/cpu.h | 9 +++ target-i386/kvm.c | 33 ++++++++-- 3 files changed, 214 insertions(+), 6 deletions(-)Please don't add new CPU command line options without matching QOM properties. There are patch series in the works that convert the CPU definitions to QOM subclasses, the parameters then need to be set on the X86CPU object instance.
I found: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg00587.html Is this the right set?
So Igor has a patch set that does a similar change like above. I so far have not found it on QEMU-DEVEL. Please provide a pointer to this patch set.It seems to be a good idea to wait for the CPU properties series from Igor to be applied, before implementing this. It should make the new code much simpler.
I will be re-working this change, and wait (for v2) until master has changed to the new way.Note that the convention for QOM properties is descriptive-name-with-dashes rather than shortened_abbrev_with_underscore.
-Don
[Prev in Thread] | Current Thread | [Next in Thread] |