[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kerne
From: |
Xiao Guangrong |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] update kvm related the head file from kernel |
Date: |
Fri, 07 Sep 2012 17:39:20 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 |
Hi Jan,
Thanks for your review.
On 09/07/2012 04:49 PM, Jan Kiszka wrote:
>> +#ifdef __KVM_HAVE_READONLY_MEM
>> + __u8 write_readonly_mem;
>> +#endif
>> } mmio;
>> /* KVM_EXIT_HYPERCALL */
>> struct {
>> @@ -618,6 +625,9 @@ struct kvm_ppc_smmu_info {
>> #define KVM_CAP_PPC_GET_SMMU_INFO 78
>> #define KVM_CAP_S390_COW 79
>> #define KVM_CAP_PPC_ALLOC_HTAB 80
>> +#ifdef __KVM_HAVE_READONLY_MEM
>> +#define KVM_CAP_READONLY_MEM 81
>> +#endif
>
> Sorry for commenting on the wrong patch, this must be fixed in the
> kernel: no more conditional CAPs, please.
There are some common code depend on KVM_CAP_READONLY_MEM, such as,
check_memory_region_flags() and write_readonly_mem field in mmio-exit-info.
Yes, we can use #ifdef CONFIG_X86 to enable it only on x86, but it
is hard to expand this feather to other arches in the further.
So, i used __KVM_HAVE_READONLY_MEM and only defined it on x86. :)
- [Qemu-devel] [PATCH 0/3] support kvm readonly memory slot in qemu, Liu Sheng, 2012/09/07
- [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Liu Sheng, 2012/09/07
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/07
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Avi Kivity, 2012/09/09
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Kevin O'Connor, 2012/09/10
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Anthony Liguori, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Jan Kiszka, 2012/09/11
- Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu, Kevin O'Connor, 2012/09/11