[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping |
Date: |
Fri, 07 Sep 2012 16:53:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-09-07 16:41, Peter Maydell wrote:
> On 7 September 2012 00:03, Jan Kiszka <address@hidden> wrote:
>> The old arithmetic assumed 32 physical address bits which is no longer
>> true for ARM since 3cc0cd61f4.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> hw/musicpal.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/musicpal.c b/hw/musicpal.c
>> index ad725b5..10c2c16 100644
>> --- a/hw/musicpal.c
>> +++ b/hw/musicpal.c
>> @@ -1583,7 +1583,7 @@ static void musicpal_init(ram_addr_t ram_size,
>> * image is smaller than 32 MB.
>> */
>> #ifdef TARGET_WORDS_BIGENDIAN
>> - pflash_cfi02_register(0-MP_FLASH_SIZE_MAX, NULL,
>> + pflash_cfi02_register(0x100000000-MP_FLASH_SIZE_MAX, NULL,
>
> I don't think this will compile on a 32 bit system, will it?
> You probably want an ULL suffix.
It does as the result always fits in 32 bits. But I can add that if you
prefer.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/06
- Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Peter Maydell, 2012/09/07
- Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Peter Maydell, 2012/09/07
- Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Blue Swirl, 2012/09/08
- Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- [Qemu-devel] [PATCH v2] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- Re: [Qemu-devel] [PATCH v2] musicpal: Fix flash mapping, Peter Maydell, 2012/09/08
- Re: [Qemu-devel] [PATCH v2] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- [Qemu-devel] [PATCH v2a] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- Re: [Qemu-devel] [PATCH v2a] musicpal: Fix flash mapping, Blue Swirl, 2012/09/08