[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb |
Date: |
Fri, 07 Sep 2012 19:09:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 07/09/2012 19:04, Jeff Cody ha scritto:
> On 09/07/2012 12:27 PM, Paolo Bonzini wrote:
>> Il 30/08/2012 20:47, Jeff Cody ha scritto:
>>> @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = {
>>> [IF_SCSI] = 7,
>>> };
>>>
>>> +static void block_job_cb(void *opaque, int ret);
>>> +
>>> /*
>>> * We automatically delete the drive when a device using it gets
>>> * unplugged. Questionable feature, but we can't just drop it.
>>
>> Can you avoid the forward declaration?
>>
>> Paolo
>>
>
> Yes, sure - honestly, I added this patch in, but I assumed that the
> similar patch of yours to support mirroring would go in first, making
> this patch moot.
I now took this patch of yours in my tree (minus the forward
declaration), so...
Paolo