Re: [Qemu-devel] [PATCH 2/7] Drop cpu_list_id macro

[Igor Mammedov]

On Wed,  5 Sep 2012 17:41:08 -0300
Eduardo Habkost <address@hidden> wrote:

> From: Peter Maydell <address@hidden>
> 
> Since the only user of the extended cpu_list_id() format
> was the x86 ?model/?dump/?cpuid output, we can drop it
> completely.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> ---
>  cpus.c            | 6 ++----
>  linux-user/main.c | 6 ++----
>  target-i386/cpu.c | 4 ++--
>  target-i386/cpu.h | 4 ++--
>  4 files changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index e476a3c..4b726ef 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1192,10 +1192,8 @@ void set_cpu_log_filename(const char *optarg)
>  void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg)
>  {
>      /* XXX: implement xxx_cpu_list for targets that still miss it */
> -#if defined(cpu_list_id)
> -    cpu_list_id(f, cpu_fprintf, optarg);
> -#elif defined(cpu_list)
> -    cpu_list(f, cpu_fprintf); /* deprecated */
> +#if defined(cpu_list)
> +    cpu_list(f, cpu_fprintf);
>  #endif
>  }
>  
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 1a1c661..6e66e5d 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -3143,10 +3143,8 @@ static void handle_arg_cpu(const char *arg)
>      cpu_model = strdup(arg);
>      if (cpu_model == NULL || is_help_option(cpu_model)) {
>          /* XXX: implement xxx_cpu_list for targets that still miss it */
> -#if defined(cpu_list_id)
> -        cpu_list_id(stdout, &fprintf, "");
> -#elif defined(cpu_list)
> -        cpu_list(stdout, &fprintf); /* deprecated */
> +#if defined(cpu_list)
> +        cpu_list(stdout, &fprintf);
>  #endif
>          exit(1);
>      }
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 5c98064..d2af0ff 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1073,8 +1073,8 @@ static void listflags(char *buf, int bufsize,
> uint32_t fbits, }
>  }
>  
> -/* generate CPU information */
> -void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf, const char
> *optarg) +/* generate CPU information. */
> +void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf)
>  {
>      x86_def_t *def;
>      char buf[256];
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 0677502..49e0259 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -792,7 +792,7 @@ typedef struct CPUX86State {
>  
>  X86CPU *cpu_x86_init(const char *cpu_model);
>  int cpu_x86_exec(CPUX86State *s);
> -void x86_cpu_list (FILE *f, fprintf_function cpu_fprintf, const char
> *optarg); +void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf);
>  void x86_cpudef_setup(void);
>  int cpu_x86_support_mca_broadcast(CPUX86State *env);
>  
> @@ -976,7 +976,7 @@ static inline CPUX86State *cpu_init(const char
> *cpu_model) #define cpu_exec cpu_x86_exec
>  #define cpu_gen_code cpu_x86_gen_code
>  #define cpu_signal_handler cpu_x86_signal_handler
> -#define cpu_list_id x86_cpu_list
> +#define cpu_list x86_cpu_list
>  #define cpudef_setup x86_cpudef_setup
>  
>  #define CPU_SAVE_VERSION 12
Reviewed-by: Igor Mammedov <address@hidden>