Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 08/09/2012 09:15, Blue Swirl ha scritto:
>>> Preferably some which don't
>>> > break on 'qemu -nodefault -device isa-serial,chardev=foo'.
>> Add a qdev property? The base address check can't be correct, the
>> serial device could be the only one in the board and wired to wakeup
>> but still use a different iobase.
>
> Could work, but the default value for the property would still be
> "depending on the iobase".
>
>> One way could be to check if chr == serial_hds[0] or rather, pass the
>> wakeup reason code from board level based on this check.
>
> That doesn't work for -device.

I think the wiring is wrong here.  Why would a device assert the wakeup
reason?

I assume on bare metal, the device asserts a single line and then
something devices how to treat the output from a given device.

IOW, shouldn't it be something more like, SerialState exports a qemu_irq
and then the machine code decides whether to route that irq to a call to
qemu_system_wakeup().  Then depending on whether this is coming from
serial[1], determines which reason is used.

Regards,

Anthony Liguori

>
> Paolo