|
From: | Hans de Goede |
Subject: | Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device |
Date: | Tue, 11 Sep 2012 14:16:55 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
Hi, On 09/11/2012 02:03 PM, Alon Levy wrote:
Hi, Sorry for top posting, but trying to summarize this thread here. I must say I like Gerd's approach, as it unifies code paths mostly, instead of having yet another interface where we do 2 way capabilities negotiation, with all the extra test matrix entries that would entice for full testing, we keep things simple.So you are suggesting to send the message to both parties, and ignore it in the guest agent if it sees a qxl device.
No, slightly more sophisticated, what I'm suggesting is that the server will not forward the VDAgentMonitorsConfig to the agent, if the qxl-dev's int_mask contains QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. This should work because either we have a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG aware driver, ie the new kms driver and it sets QXL_INTERRUPT_CLIENT_MONITORS_CONFIG in int_mask, or we don't and then the right thing to do is send the message to the agent to deal with it. This will need spice-server <-> qemu/hw/qxl.c coordination, but I assume we will need some changes there anyway to set QXL_INTERRUPT_CLIENT_MONITORS_CONFIG, the qemu/hw/qxl.c function patching the MonitorsConfig into the romspace, and setting the irq in int_pending, could return whether or not the flag was set in int_mask for example. Regards, Hans
[Prev in Thread] | Current Thread | [Next in Thread] |