[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: usbredir fixes
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] configure: usbredir fixes |
Date: |
Wed, 12 Sep 2012 09:47:56 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6 |
On 11.09.2012 22:57, Aurelien Jarno wrote:
> usbredir is only used by system emulation, so add the libraries to
> libs_softmmu instead of LIBS.
Fwiw, original code breaks user-static build - not it only
tries to link with unused library but also some distros
does not package/provide static (.a) library for
libusbredirparser (I dunno if it is a general issue).
This patch fixes that. It has been in Debian as a bugfix
since the time usbredir were introduced.
> Cc: Michael Tokarev <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7656c32..cf2621a 100755
> --- a/configure
> +++ b/configure
> @@ -2763,7 +2763,7 @@ if test "$usb_redir" != "no" ; then
> usb_redir_cflags=$($pkg_config --cflags libusbredirparser
> 2>/dev/null)
> usb_redir_libs=$($pkg_config --libs libusbredirparser 2>/dev/null)
> QEMU_CFLAGS="$QEMU_CFLAGS $usb_redir_cflags"
> - LIBS="$LIBS $usb_redir_libs"
> + libs_softmmu="$LIBS $usb_redir_libs"
> else
> if test "$usb_redir" = "yes"; then
> feature_not_found "usb-redir"