[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 15/25] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERRO
From: |
Jason Baron |
Subject: |
[Qemu-devel] [PATCH 15/25] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask |
Date: |
Thu, 13 Sep 2012 16:12:45 -0400 |
From: Jan Kiszka <address@hidden>
Both bits are added to the write-1-to-clear mask by default. As the
smbus device does not allow writes at all, we have to remove it from
that mask, also to avoid triggering a runtime assertion.
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Jason Baron <address@hidden>
---
hw/q35_smbus.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/q35_smbus.c b/hw/q35_smbus.c
index 0ee404e..42dfcb1 100644
--- a/hw/q35_smbus.c
+++ b/hw/q35_smbus.c
@@ -97,6 +97,10 @@ static int ich9_smbus_initfn(PCIDevice *d)
pci_set_word(d->wmask + PCI_STATUS,
PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY);
+ pci_set_word(d->w1cmask + PCI_STATUS,
+ pci_get_word(d->w1cmask + PCI_STATUS) &
+ ~(PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY));
+
/* TODO? D31IP.SMIP in chipset configuration space */
pci_config_set_interrupt_pin(d->config, 0x01); /* interrupt pin 1 */
--
1.7.1
- [Qemu-devel] [PATCH 13/25] q35: Suppress SMM BIOS initialization under KVM, (continued)
- [Qemu-devel] [PATCH 13/25] q35: Suppress SMM BIOS initialization under KVM, Jason Baron, 2012/09/13
- [Qemu-devel] [PATCH 03/25] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle, Jason Baron, 2012/09/13
- [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Jason Baron, 2012/09/13
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Markus Armbruster, 2012/09/21
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Jason Baron, 2012/09/21
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Markus Armbruster, 2012/09/24
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Jason Baron, 2012/09/24
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Markus Armbruster, 2012/09/26
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Kevin Wolf, 2012/09/26
- Re: [Qemu-devel] [PATCH 04/25] ahci: add ide device initialization helper, Jason Baron, 2012/09/27
[Qemu-devel] [PATCH 15/25] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask,
Jason Baron <=
[Qemu-devel] [PATCH 09/25] pcie: pass pcie window size to pcie_host_mmcfg_update(), Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 17/25] q35: Add kvmclock support, Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 14/25] q35: Fix non-PCI IRQ processing in ich9_lpc_update_apic, Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 20/25] pcie: drop version_id field for live migration, Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 25/25] q35: automatically load the q35 dsdt table, Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 22/25] ahci: properly reset PxCMD on HBA reset, Jason Baron, 2012/09/13
[Qemu-devel] [PATCH 01/25] pci: pci capability must be in PCI space, Jason Baron, 2012/09/13