[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file |
Date: |
Fri, 14 Sep 2012 08:45:18 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 11, 2012 at 12:23:37PM +0200, Kevin Wolf wrote:
> Am 05.09.2012 15:26, schrieb address@hidden:
> > From: Dunrong Huang <address@hidden>
> >
> > The caller would not delete temporary file after failed get_tmp_filename().
> >
> > Signed-off-by: Dunrong Huang <address@hidden>
>
> Thanks, applied to the block branch.
For the record, using the close(2) errno after calling unlink(2) isn't
a good idea. We should follow the docs and preserve errno carefully.
It's the exact issue I pointed out on the original patch.
Stefan
Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file, Kevin Wolf, 2012/09/11
- Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file,
Stefan Hajnoczi <=