[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/11] block/curl: Fix wrong free statement
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 04/11] block/curl: Fix wrong free statement |
Date: |
Fri, 14 Sep 2012 14:39:05 +0200 |
From: Stefan Weil <address@hidden>
Report from smatch:
block/curl.c:546 curl_close(21) info: redundant null check on s->url calling
free()
The check was redundant, and free was also wrong because the memory
was allocated using g_strdup.
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/curl.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index e7c3634..c1074cd 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -542,8 +542,7 @@ static void curl_close(BlockDriverState *bs)
}
if (s->multi)
curl_multi_cleanup(s->multi);
- if (s->url)
- free(s->url);
+ g_free(s->url);
}
static int64_t curl_getlength(BlockDriverState *bs)
--
1.7.6.5
- [Qemu-devel] [PULL 00/11] Block patches, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 04/11] block/curl: Fix wrong free statement,
Kevin Wolf <=
- [Qemu-devel] [PATCH 05/11] vdi: Fix warning from clang, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 01/11] sheepdog: fix savevm and loadvm, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 08/11] qapi: Add SnapshotInfo and ImageInfo., Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 02/11] ATAPI: STARTSTOPUNIT only eject/load media if powercondition is 0, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 07/11] ahci: properly reset PxCMD on HBA reset, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 03/11] ide: Fix error messages from static code analysis (no real error), Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 06/11] block: fix block tray status, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 10/11] Don't require encryption password for 'qemu-img info' command, Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 09/11] qemu-img: Add json output option to the info command., Kevin Wolf, 2012/09/14
- [Qemu-devel] [PATCH 11/11] block: Don't forget to delete temporary file, Kevin Wolf, 2012/09/14