[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] block: after creating a live snapshot, make old
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH 8/8] block: after creating a live snapshot, make old image read-only |
Date: |
Fri, 14 Sep 2012 09:41:13 -0400 |
Currently, after a live snapshot of a drive, the image that has
been 'demoted' to be below the new active layer remains r/w.
This patch reopens it read-only.
Note that we do not check for error on the reopen(), because we
will not abort the snapshots if the reopen fails.
This patch depends on the bdrv_reopen() series.
Signed-off-by: Jeff Cody <address@hidden>
---
blockdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 785e999..6330327 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -803,6 +803,11 @@ void qmp_transaction(BlockdevActionList *dev_list, Error
**errp)
QSIMPLEQ_FOREACH(states, &snap_bdrv_states, entry) {
/* This removes our old bs from the bdrv_states, and adds the new bs */
bdrv_append(states->new_bs, states->old_bs);
+ /* We don't need (or want) to use the transactional
+ * bdrv_reopen_multiple() across all the entries at once, because we
+ * don't want to abort all of them if one of them fails the reopen */
+ bdrv_reopen(states->new_bs, states->new_bs->open_flags & ~BDRV_O_RDWR,
+ NULL);
}
/* success */
--
1.7.11.4
- Re: [Qemu-devel] [PATCH 2/8] block: add live block commit functionality, (continued)
[Qemu-devel] [PATCH 3/8] blockdev: rename block_stream_cb to a generic block_job_cb, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QERR_TOP_NOT_FOUND, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 6/8] QAPI: add command for live block commit, 'block-commit', Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 8/8] block: after creating a live snapshot, make old image read-only,
Jeff Cody <=
[Qemu-devel] [PATCH 1/8] block: add support functions for live commit, to find and delete images., Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 5/8] block: helper function, to find the base image of a chain, Jeff Cody, 2012/09/14
[Qemu-devel] [PATCH 7/8] qemu-iotests: add initial tests for live block commit, Jeff Cody, 2012/09/14