[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v0 07/10] fdt_generic: First revision
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC v0 07/10] fdt_generic: First revision |
Date: |
Mon, 17 Sep 2012 11:48:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
Il 17/09/2012 11:02, Peter A. G. Crosthwaite ha scritto:
> First revision of fdt generic infrastructure. These modules allow
> for fdt generic machine models, which create machines to match a device
> tree specification.
Ok, so here is the famous coroutine-based FDT generation. :)
It does look pretty, to be fair.
However, as things stand there is nothing (I think) that really requires
coroutines. A simple 2-pass initialization would do, with links and
irqs connected on the second pass. I'm wondering how your patch fares
in terms of error handling for example; can you end up with
partially-uninitialized devices or infinite loops? If so, why not?
It would be nice if you included some simple qtest test cases. They
would generate a few machines with different device trees and check that
the output of "info qtree" matches somewhat the device tree. Rough
checks should not be hard to implement, and would provide some guidance
to people who want to hack the code.
Paolo
- [Qemu-devel] [RFC v0 00/10] Microblaze generic FDT framework, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 01/10] device_tree: allow offsets for cell properties, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 02/10] device_tree: return Error* from prop getters, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 03/10] device_tree: allow property getters to inherit, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 04/10] device_tree: get_prop(): memdup returned properties, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 05/10] qemu-coroutine: Add simple work queue support, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 08/10] pflash_cfi01: Added fdt generic platform support, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 09/10] microblaze_generic_fdt: first revision, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 07/10] fdt_generic: First revision, Peter A. G. Crosthwaite, 2012/09/17
- Re: [Qemu-devel] [RFC v0 07/10] fdt_generic: First revision,
Paolo Bonzini <=
- [Qemu-devel] [RFC v0 06/10] device_tree: Extended interface for fdt_generic, Peter A. G. Crosthwaite, 2012/09/17
- [Qemu-devel] [RFC v0 10/10] serial: added fdt generic platform support, Peter A. G. Crosthwaite, 2012/09/17