[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to retu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void |
Date: |
Mon, 17 Sep 2012 20:25:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
Il 17/09/2012 19:20, Peter Maydell ha scritto:
>> > Couldn't that mean simply that the tb for instance wasn't mapped
>> > anywhere? That's the KVM case, at least.
> Hmm. For TCG there are certainly some cases where failure to
> cpu_restore_state() means that the current CPU state is now broken;
> that should be fatal (and I'm not sure there are any cases where
> failure is OK. I think calls are generally protected by
> checking that tb_find_pc() returned non-NULL, so we shouldn't
> be trying to restore state unless we really were in the middle
> of a TB that we know about and can translate.)
>
> I'm not sure what the TB concept means for KVM -- after all KVM
> doesn't do any translation...
Nothing, but in some cases cpu_restore_state() is called from exception
handling helpers or something like that. My knowledge is spotty.
Paolo
- Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o, (continued)
Re: [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg, Blue Swirl, 2012/09/17