[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error) |
Date: |
Mon, 17 Sep 2012 17:08:47 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Jan Kiszka <address@hidden> writes:
> On 2012-09-17 22:14, Stefan Weil wrote:
>> This configuration requires CONFIG_i8254:
>>
>> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> This is wrong. The pcspk "audio card" is registered automatically for
> those targets that support it.
>
>>
>> Reported-by: Vassili Karpov (malc) <address@hidden>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> default-configs/xtensa-softmmu.mak | 1 +
>> default-configs/xtensaeb-softmmu.mak | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/default-configs/xtensa-softmmu.mak
>> b/default-configs/xtensa-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensa-softmmu.mak
>> +++ b/default-configs/xtensa-softmmu.mak
>> @@ -1,5 +1,6 @@
>> # Default configuration for Xtensa
>>
>> +CONFIG_I8254=y
>
> And this wrong as well. xtensa does not include any speaker, nor does it
> include a PIT.
I was looking for docs and couldn't find any that indicated it contained
a PIT either.
Regards,
Anthony Liguori
>
> Jan
>
>> CONFIG_SERIAL=y
>> CONFIG_OPENCORES_ETH=y
>> CONFIG_PFLASH_CFI01=y
>> diff --git a/default-configs/xtensaeb-softmmu.mak
>> b/default-configs/xtensaeb-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensaeb-softmmu.mak
>> +++ b/default-configs/xtensaeb-softmmu.mak
>> @@ -1,5 +1,6 @@
>> # Default configuration for Xtensa
>>
>> +CONFIG_I8254=y
>> CONFIG_SERIAL=y
>> CONFIG_OPENCORES_ETH=y
>> CONFIG_PFLASH_CFI01=y
>>