Re: [Qemu-devel] [PATCH V3 4/5] libqblock test build system

[Paolo Bonzini]

Il 18/09/2012 11:01, Wenchao Xia ha scritto:
>   Created a new directory in tests, make chekc-libqblock will build an
> executable binrary, make clean will delete it.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  .gitignore                       |    1 +
>  Makefile                         |    1 +
>  tests/Makefile                   |    3 +++
>  tests/libqblock/Makefile         |   32 ++++++++++++++++++++++++++++++++
>  tests/libqblock/libqblock-test.c |    4 ++++
>  5 files changed, 41 insertions(+), 0 deletions(-)
>  create mode 100644 tests/libqblock/Makefile
>  create mode 100644 tests/libqblock/libqblock-test.c
> 
> diff --git a/.gitignore b/.gitignore
> index 824c0d2..eccb637 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -95,3 +95,4 @@ cscope.*
>  tags
>  TAGS
>  *~
> +tests/libqblock/*.bin
> diff --git a/Makefile b/Makefile
> index b0b9b8d..de8ea17 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -238,6 +238,7 @@ clean:
>       rm -rf qapi-generated
>       rm -rf qga/qapi-generated
>       $(MAKE) -C tests/tcg clean
> +     $(MAKE) -C tests/libqblock clean
>       for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard libqblock; do \
>       if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
>       rm -f $$d/qemu-options.def; \
> diff --git a/tests/Makefile b/tests/Makefile
> index 26a67ce..69af1e2 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -148,4 +148,7 @@ check-unit: $(patsubst %,check-%, $(check-unit-y))
>  check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-unit check-qtest
>  
> +check-libqblock:
> +     $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C tests/libqblock 
> V="$(V)" TARGET_DIR="$*/" check-libqblock,)

Please just put everything in tests/Makefile. "make check" should run it
if LIBTOOL is available.

> +libqblock-test.bin: $(libqblock-test-objs) $(libqblock-la-path)
> +     $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) 
> -shared -rpath $(libdir) -o $@ $^,"  lt LINK $@")

.bin looks so MS-DOS. :)

Paolo