qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target


From: Michael Tokarev
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file
Date: Tue, 18 Sep 2012 16:29:47 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6

Has it been applied to anything?  I don't think so.
Is it still needed?

Thanks,

/mjt

On 07.06.2012 20:23, Andreas Färber wrote:
> config-devices.mak.d is included from Makefile.target, i.e. from inside
> the *-softmmu/ directory. It included the directory path, so never
> applied to the actual config-devices.mak. Symptoms were spurious
> dependency issues with default-configs/pci.mak.
> 
> Fix by using `basename` to strip the directory path.
> 
> Reported-by: Gerhard Wiesinger <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  Seems I forgot to send this out before 1.1...
> 
>  scripts/make_device_config.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> index 5d14885..0778fe2 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -25,4 +25,4 @@ done
>  process_includes $src > $dest
>  
>  cat $src $all_includes | grep -v '^include' > $dest
> -echo "$1: $all_includes" > $dep
> +echo "`basename $1`: $all_includes" > $dep




reply via email to

[Prev in Thread] Current Thread [Next in Thread]