[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga |
Date: |
Wed, 19 Sep 2012 13:35:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
>> + * 0x0400 -> 0x041f vga ioports (0x3c0 -> 0x3df), remapped 1:1
>
> Do they support word accesses to set both index and data?
>
>> + * 0x0500 -> 0x0515 bochs dispi interface registers, mapped flat without
>> + * index/data ports. Use (index << 1) as offset for
>> + * (16bit) register access.
>> + */
>
> BAR should disappear with -M old.
Sure. I have a patch in flight which adds the pc-1.3 machine type, once
this is in I can easily add the compat stuff.
>> +static const MemoryRegionOps pci_vga_ioport_ops = {
>> + .read = pci_vga_ioport_read,
>> + .write = pci_vga_ioport_write,
>> + .valid.min_access_size = 1,
>> + .valid.max_access_size = 4,
>> + .impl.min_access_size = 1,
>> + .impl.max_access_size = 1,
>> + .endianness = DEVICE_LITTLE_ENDIAN,
>> +};
>
> Looks like word writes are supported provided the memory API breaks up
> writes in little endian order. Better to make it explicit.
Like the attached incremental patch?
cheers,
Gerd
0001-fixup-vga-mmio.patch
Description: Text document