qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling
Date: Wed, 19 Sep 2012 07:34:29 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0

On 09/19/2012 06:02 AM, Alexander Graf wrote:
> Richard, please double-check all the ilc passing again with the spec.

I'll look again.

But I do recall that the spec is consistent in placing a 3-bit field (values 
1-3)
shifted one bit left into the larger 32-bit field, so that in essence the value
is always the real instruction length.

However, qemu was not consistent in performing that multiplication.  So there
will be some place that gets changed because of this.  Frankly I think it would
be least confusing to always manipulate the full instruction length and never
explicitly perform the multiply.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]