[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/41] savevm: Remove qemu_fseek()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 29/41] savevm: Remove qemu_fseek() |
Date: |
Fri, 21 Sep 2012 14:46:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 21/09/2012 10:47, Juan Quintela ha scritto:
> It has no users, and is only half implemented.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> qemu-file.h | 1 -
> savevm.c | 21 ---------------------
> 2 files changed, 22 deletions(-)
>
> diff --git a/qemu-file.h b/qemu-file.h
> index d8487cd..7fe7274 100644
> --- a/qemu-file.h
> +++ b/qemu-file.h
> @@ -232,6 +232,5 @@ static inline void qemu_get_sbe64s(QEMUFile *f, int64_t
> *pv)
> }
>
> int64_t qemu_ftell(QEMUFile *f);
> -int64_t qemu_fseek(QEMUFile *f, int64_t pos, int whence);
>
> #endif
> diff --git a/savevm.c b/savevm.c
> index 1ec6ff1..6865862 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -676,27 +676,6 @@ int64_t qemu_ftell(QEMUFile *f)
> return f->buf_offset - f->buf_size + f->buf_index;
> }
>
> -int64_t qemu_fseek(QEMUFile *f, int64_t pos, int whence)
> -{
> - if (whence == SEEK_SET) {
> - /* nothing to do */
> - } else if (whence == SEEK_CUR) {
> - pos += qemu_ftell(f);
> - } else {
> - /* SEEK_END not supported */
> - return -1;
> - }
> - if (f->put_buffer) {
> - qemu_fflush(f);
> - f->buf_offset = pos;
> - } else {
> - f->buf_offset = pos;
> - f->buf_index = 0;
> - f->buf_size = 0;
> - }
> - return pos;
> -}
> -
> int qemu_file_rate_limit(QEMUFile *f)
> {
> if (f->rate_limit)
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 19/41] buffered_file: unfold migrate_fd_put_buffer, (continued)
- [Qemu-devel] [PATCH 19/41] buffered_file: unfold migrate_fd_put_buffer, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 15/41] migration: Add dirty_pages_rate to query migrate output, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 27/41] savevm: unexport qemu_fflush, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 23/41] buffered_file: We can access directly to bandwidth_limit, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 26/41] migration: make migrate_fd_wait_for_unfreeze() return errors, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 29/41] savevm: Remove qemu_fseek(), Juan Quintela, 2012/09/21
- Re: [Qemu-devel] [PATCH 29/41] savevm: Remove qemu_fseek(),
Paolo Bonzini <=
- [Qemu-devel] [PATCH 30/41] savevm: make qemu_fflush() return an error code, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 38/41] block-migration: handle errors with the return codes correctly, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 40/41] savevm: make qemu_file_put_notify() return errors, Juan Quintela, 2012/09/21
- [Qemu-devel] [PATCH 36/41] block-migration: make flush_blks() return errors, Juan Quintela, 2012/09/21