[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint |
Date: |
Sat, 22 Sep 2012 16:55:37 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 14, 2012 at 07:18:17AM +0200, Stefan Weil wrote:
> Am 14.09.2012 00:20, schrieb Richard Henderson:
> >On 09/13/2012 03:03 PM, Peter Maydell wrote:
> >>Hard to come up with a snappy name for "register which is the Nth
> >>input argument if input args are in registers, but an arbitrary
> >>temp reg otherwise, and which is in the forbidden list for the L
> >>constraint"...
> >I'm more than happy to let "register which is ..." be a comment
> >just before the definitions of TCG_REG_Ln at the top...
> >
> >
> >
> >r~
> >
>
> This looks like a pragmatic solution.
>
> If everybody agrees, I'll send an updated patch.
>
> Or Aurelien or Blue can commit this series and fix the comment
> as suggested by Richard. Maybe a comment in theprologue code
> would also be good.
>
> Thanks to all reviewers.
>
Your patch didn't even compiled on i386. I have fixed it. I also changed
the prologue on i386 to not load the TB address through a register,
given i386 has so many addressing mode. This way the issue is solved.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 0/4] Fix and clean tcg_target_get_call_iarg_regs_count, Stefan Weil, 2012/09/13
- [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Stefan Weil, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Aurelien Jarno, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Richard Henderson, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Aurelien Jarno, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Peter Maydell, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Richard Henderson, 2012/09/13
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint, Stefan Weil, 2012/09/14
- Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint,
Aurelien Jarno <=
[Qemu-devel] [PATCH 3/4] tcg/i386: Remove unused registers from tcg_target_call_iarg_regs, Stefan Weil, 2012/09/13
[Qemu-devel] [PATCH 4/4] tcg: Remove tcg_target_get_call_iarg_regs_count, Stefan Weil, 2012/09/13
[Qemu-devel] [PATCH 1/4] w64: Fix TCG helper functions with 5 arguments, Stefan Weil, 2012/09/13
Re: [Qemu-devel] [PATCH v2 0/4] Fix and clean tcg_target_get_call_iarg_regs_count, Richard Henderson, 2012/09/13