Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

[Kevin Wolf]

Am 26.09.2012 17:56, schrieb Paolo Bonzini:
> Job pausing reuses the existing support for cancellable sleeps.  A pause
> happens at the next sleeping point and lasts until the coroutine is
> re-entered explicitly.  Cancellation was already doing a forced resume,
> so implement it explicitly in terms of resume.
> 
> Paused jobs cannot be canceled without first resuming them.  This ensures
> that I/O errors are never missed by management.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

I think there's a problem with terminology at least. What does "paused"
really mean? Is it that the job has been requested to pause, or that it
has actually yielded and is inactive?

The commit message seems to use the latter semantics (which I would
consider the intuitive one), the QMP documentation leaves it unclear,
but the code actually implements the former semantics.

Kevin