[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error |
Date: |
Thu, 27 Sep 2012 16:50:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 27/09/2012 15:41, Kevin Wolf ha scritto:
>> > +BlockErrorAction block_job_error_action(BlockJob *job, BlockDriverState
>> > *bs,
>> > + BlockdevOnError on_err,
>> > + int is_read, int error)
>> > +{
>> > + BlockErrorAction action;
>> > +
>> > + switch (on_err) {
>> > + case BLOCKDEV_ON_ERROR_ENOSPC:
>> > + action = (error == ENOSPC) ? BDRV_ACTION_STOP :
>> > BDRV_ACTION_REPORT;
>> > + break;
>> > + case BLOCKDEV_ON_ERROR_STOP:
>> > + action = BDRV_ACTION_STOP;
>> > + break;
>> > + case BLOCKDEV_ON_ERROR_REPORT:
>> > + action = BDRV_ACTION_REPORT;
>> > + break;
>> > + case BLOCKDEV_ON_ERROR_IGNORE:
>> > + action = BDRV_ACTION_IGNORE;
>> > + break;
>> > + default:
>> > + abort();
>> > + }
> Isn't this a duplication of bdrv_get_error_action()?
bdrv_get_error_action() has this:
BlockdevOnError on_err = is_read ? bs->on_read_error : bs->on_write_error;
It can use some refactoring to commonize the switch statement, but
it's not a direct replacement.
Paolo
- Re: [Qemu-devel] [PATCH v2 11/45] iostatus: move BlockdevOnError declaration to QAPI, (continued)
- [Qemu-devel] [PATCH v2 13/45] iostatus: reorganize io error code, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 10/45] iostatus: rename BlockErrorAction, BlockQMPEventAction, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 12/45] iostatus: change is_read to a bool, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 14/45] block: introduce block job error, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 16/45] blkdebug: process all set_state rules in the old state, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 17/45] qemu-iotests: map underscore to dash in QMP argument names, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 20/45] block: add bdrv_query_stats, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 19/45] block: add bdrv_query_info, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 18/45] qemu-iotests: add tests for streaming error handling, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 22/45] block: introduce new dirty bitmap functionality, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 23/45] block: export dirty bitmap information in query-block, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 26/45] mirror: introduce mirror job, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 24/45] block: add block-job-complete, Paolo Bonzini, 2012/09/26
- [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command, Paolo Bonzini, 2012/09/26