[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/13] tcg: add tcg_reg_sync()

From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH 02/13] tcg: add tcg_reg_sync()
Date: Thu, 27 Sep 2012 22:00:20 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Sep 27, 2012 at 11:24:34AM -0700, Richard Henderson wrote:
> On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> > Add a new function tcg_reg_sync() to synchronize the canonical location
> > of a temp with the value in the associated register, but without freeing
> > it. Rewrite tcg_reg_free() to first call tcg_reg_sync() and then to free
> > the register.
> > 
> > Signed-off-by: Aurelien Jarno <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> > +/* sync register 'reg' by saving it to the corresponding temporary */
> > +static inline void tcg_reg_sync(TCGContext *s, int reg)
> Isn't the compiler good enough at deciding inlining?

Surprisingly the compiler doesn't inline that many things. For example
all the tcg_reg_alloc_* functions are used only once, but are not

Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]