Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals and temps

[Aurelien Jarno]

On Thu, Sep 27, 2012 at 12:13:25PM -0700, Richard Henderson wrote:
> On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> > @@ -1706,11 +1718,9 @@ static void tcg_reg_alloc_mov(TCGContext *s, const 
> > TCGOpDef *def,
> >          if (!ots->mem_allocated) {
> >              temp_allocate_frame(s, args[0]);
> >          }
> > -        if (ts->val_type == TEMP_VAL_REG) {
> > -            tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, 
> > ots->mem_offset);
> > -            if (IS_DEAD_ARG(1)) {
> > -                temp_dead(s, args[1]);
> > -            }
> > +        tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> > +        if (IS_DEAD_ARG(1)) {
> > +            temp_dead(s, args[1]);
> >          }
> >          temp_dead(s, args[0]);
> >      } else if (ts->val_type == TEMP_VAL_CONST) {
> 
> Did this hunk belong to a different patch?  It seems like it belongs
> with the tcg_reg_alloc_mov rewrite.

Yes, it was a simplification meant to go in the patch 7, but it ended up
at the wrong place (the assert above already ensure that ts->val_type ==
TEMP_VAL_REG.

I'll move it to the write patch.

> If it actually depends on patches 7-8, then perhaps a reorder is better.
> 
> 
> r~
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net