[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL for Kevin 00/19] Block job improvements part 1

From: Eric Blake
Subject: Re: [Qemu-devel] [PULL for Kevin 00/19] Block job improvements part 1
Date: Fri, 28 Sep 2012 09:57:00 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1

On 09/28/2012 09:22 AM, Paolo Bonzini wrote:
> Kevin,
> the following changes since commit ac05f3492421caeb05809ffa02c6198ede179e43:
>   add a boot parameter to set reboot timeout (2012-09-25 20:05:04 -0500)
> are available in the git repository at:
>   git://github.com/bonzini/qemu.git blkmirror-job-1.3-part1
> for you to fetch changes up to ed306a929f16fda8a85561430b1ac370bde65097:
>   qemu-iotests: add tests for streaming error handling (2012-09-27 15:11:22 
> +0200)
> This message has the diff from my post of Sep 25th.  You reviewed 18 patches,
> these are 19 because of the new "qmp: add 'busy' member to BlockJobInfo" 
> patch.

I reviewed the interdiff, and it appears to address all the concerns
from v3 for these patches, other than my request to include 'type' as
part of the new event, possibly as an enum rather than freeform string.
 But since we agreed to defer that to a followup patch, it does not hold
up this series.  I also did one last sanity read through the patches.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]