[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir |
Date: |
Wed, 03 Oct 2012 20:56:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 03/10/2012 20:53, Luiz Capitulino ha scritto:
> On Wed, 03 Oct 2012 20:32:21 +0200
> Paolo Bonzini <address@hidden> wrote:
>
>> Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
>>> Defaults to /var/run.
>>
>> Please add instead --localstatedir (defaulting to ${prefix}/var), and
>> make the guest agent's directory /run inside that one. Packagers
>> already know to override --localstatedir=/var, in some cases macros even
>> do it automatically.
>
> Well, that was my first version but I discarded it for two reasons.
>
> First, --localstatedir is a host-side setting but qemu-ga is not supposed to
> run in the host. What if I want a different setting for guests?
Then you should build twice, like you do when the guest is a completely
different OS.
> Second, having /run appended to --localstatedir (or whatever we choose) may
> have a bad effect if qemu is built with --localstatedir=, where qemu-ga's
> state will be "/run" (good for Fedora, but might not be good for other
> distros or other unixes).
I'm not sure I follow, it would be --localstatedir=/var usually. Even
Fedora would not use --localstatedir=.
Paolo
>
> I'm not strong about this though, it just was my reasoning while doing this.
>
>
[Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR, Luiz Capitulino, 2012/10/03
[Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga, Luiz Capitulino, 2012/10/03
Re: [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run, Paolo Bonzini, 2012/10/03