Re: [Qemu-devel] [PATCHv3 11/20] ui/vnc: simplify and avoid strncpy

[Peter Maydell]

On 4 October 2012 12:09, Jim Meyering <address@hidden> wrote:
> From: Jim Meyering <address@hidden>
>
> Don't bother with strncpy.  There's no need for its zero-fill.
> Use g_strndup in place of g_malloc+strncpy+NUL-terminate.
>
> Signed-off-by: Jim Meyering <address@hidden>
> ---
>  ui/vnc-auth-sasl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
> index 8fba770..bfdcb46 100644
> --- a/ui/vnc-auth-sasl.c
> +++ b/ui/vnc-auth-sasl.c
> @@ -432,9 +432,7 @@ static int protocol_client_auth_sasl_start_len(VncState 
> *vs, uint8_t *data, size
>
>  static int protocol_client_auth_sasl_mechname(VncState *vs, uint8_t *data, 
> size_t len)
>  {
> -    char *mechname = g_malloc(len + 1);
> -    strncpy(mechname, (char*)data, len);
> -    mechname[len] = '\0';
> +    char *mechname = g_strndup((const char *) data, len);
>      VNC_DEBUG("Got client mechname '%s' check against '%s'\n",
>                mechname, vs->sasl.mechlist);
>

(Does the compiler really insist on that cast?)

Reviewed-by: Peter Maydell <address@hidden>

-- PMM