[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information from qemu-sockets |
Date: |
Thu, 4 Oct 2012 17:21:44 -0300 |
On Wed, 3 Oct 2012 16:36:59 +0200
Paolo Bonzini <address@hidden> wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
> ---
> qga/channel-posix.c | 8 +++++---
> 1 file modificato, 5 inserzioni(+), 3 rimozioni(-)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index e22eee6..d152827 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -181,9 +181,11 @@ static gboolean ga_channel_open(GAChannel *c, const
> gchar *path, GAChannelMethod
> break;
> }
> case GA_CHANNEL_UNIX_LISTEN: {
> - int fd = unix_listen(path, NULL, strlen(path), NULL);
> - if (fd == -1) {
> - g_critical("error opening path: %s", strerror(errno));
> + Error *local_err = NULL;
> + int fd = unix_listen(path, NULL, strlen(path), &local_err);
> + if (local_err != NULL) {
> + g_critical("%s", error_get_pretty(local_err));
> + error_free(local_err);
> return false;
> }
> ga_channel_listen_add(c, fd, true);
- [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols, (continued)
[Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
- Re: [Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information from qemu-sockets,
Luiz Capitulino <=
[Qemu-devel] [PATCH 10/18] qemu-char: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 17/18] qemu-sockets: add error propagation to inet_parse, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 15/18] qemu-sockets: add error propagation to inet_connect_addr, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 16/18] qemu-sockets: add error propagation to inet_dgram_opts, Paolo Bonzini, 2012/10/03
[Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open, Paolo Bonzini, 2012/10/03