Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

[Blue Swirl]

On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil <address@hidden> wrote:
> Am 05.10.2012 04:10, schrieb Anthony Liguori:
>
>> Avi Kivity <address@hidden> writes:
>>
>>> The hassle and compile time overhead of maintaining both 32-bit and
>>> 64-bit
>>> capable source isn't worth the tiny performance advantage which is seen
>>> on
>>> a minority of configurations.  Switch to compiling libhw only once, with
>>> target_phys_addr_t unconditionally typedefed to uint64_t.
>>>
>>> Signed-off-by: Avi Kivity <address@hidden>
>>
>> Applied. Thanks.
>>
>> Regards,
>>
>> Anthony Liguori
>>
>
>
> In a next step, we can remove libhw completely:
>
> All files from libhw/hw/*.o could as well be generated in hw/*.o,
> and hw-obj should become common-obj.
>
> Or is there still a reason why libhw is needed?

At least the trivial change to Makefile.objs does not work.

>
> Regards
>
> Stefan W.
>