[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditiona
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally |
Date: |
Fri, 05 Oct 2012 11:07:05 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Blue Swirl <address@hidden> writes:
> On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil <address@hidden> wrote:
>> Am 05.10.2012 04:10, schrieb Anthony Liguori:
>>
>>> Avi Kivity <address@hidden> writes:
>>>
>>>> The hassle and compile time overhead of maintaining both 32-bit and
>>>> 64-bit
>>>> capable source isn't worth the tiny performance advantage which is seen
>>>> on
>>>> a minority of configurations. Switch to compiling libhw only once, with
>>>> target_phys_addr_t unconditionally typedefed to uint64_t.
>>>>
>>>> Signed-off-by: Avi Kivity <address@hidden>
>>>
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>>
>>
>>
>> In a next step, we can remove libhw completely:
>>
>> All files from libhw/hw/*.o could as well be generated in hw/*.o,
>> and hw-obj should become common-obj.
>>
>> Or is there still a reason why libhw is needed?
>
> At least the trivial change to Makefile.objs does not work.
It's a little more complicated than that but not that hard.
I just sent a patch.
Regards,
Anthony Liguori
>
>>
>> Regards
>>
>> Stefan W.
>>
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, (continued)
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Edgar E. Iglesias, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Max Filippov, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Blue Swirl, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Michael Walle, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Stefan Weil, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally, Peter Maydell, 2012/10/05